httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: [Patch]: Fix mod_mime to hook in the right order. Second attempt.
Date Thu, 20 Jan 2000 19:01:25 GMT
"Paul J. Reder" wrote:
> 
> OK, I hope that I did this right this time. This should force mod_mime
> to be run before mod_mime_magic. This will enable server side includes
> to work again since the AddHandler code will get called for .shtml files.
> 
> This works in my testing, and doesn't seem to break anything else. YMMV.

For no fantastically good reason, I feel that mod_mime_magic should ask
to run before mod_mime, rather than the other way around, as you have it
here.

Chers,

Ben.

> 
> --
> Paul J. Reder
> ------------------------------------------------------------
> "Remember, Information is not knowledge; Knowledge is not Wisdom;
> Wisdom is not truth; Truth is not beauty; Beauty is not love;
> Love is not music; Music is the best." -- Frank Zappa
> 
> Index: mod_mime.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_mime.c,v
> retrieving revision 1.9
> diff -u -r1.9 mod_mime.c
> --- mod_mime.c  2000/01/19 02:42:09     1.9
> +++ mod_mime.c  2000/01/20 15:54:39
> @@ -386,7 +386,10 @@
> 
>  static void register_hooks(void)
>  {
> -    ap_hook_type_checker(find_ct,NULL,NULL,HOOK_MIDDLE);
> +    static const char * const aszPost[]={ "mod_mime_magic.c", NULL };
> +
> +    /* mod_mime_magic should be run after mod_mime, if at all. */
> +    ap_hook_type_checker(find_ct,NULL,aszPost,HOOK_MIDDLE);
>      ap_hook_post_config(mime_post_config,NULL,NULL,HOOK_MIDDLE);
>  }

--
SECURE HOSTING AT THE BUNKER! http://www.thebunker.net/hosting.htm

http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi

Mime
View raw message