httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_mime.c
Date Tue, 11 Jan 2000 21:07:41 GMT
"Ralf S. Engelschall" wrote:
> 
> In article <20000111141350.26506.qmail@hyperreal.org> you wrote:
> > ben         00/01/11 06:13:50
> >
> >   Modified:    src      CHANGES
> >                src/include httpd.h
> >                src/main http_core.c http_protocol.c http_request.c
> >                src/modules/proxy mod_proxy.c mod_proxy.h proxy_ftp.c
> >                         proxy_http.c proxy_util.c
> >                src/modules/standard mod_mime.c
> >   Log:
> >   Don't convert auth to proxy auth when it shouldn't be.
> 
> Was this really reviewed and already approved for 1.3 by Jim?

It was reviewed, and approved, unless I've gone mad (entirely possible,
its been a rough day).

> I'm +1 for the change, but IMHO it's incomplete:
> 
> | :> grep proxyreq *.c
> | mod_digest.c:                                    r->proxyreq ?
> | "Proxy-Authorization"
> | mod_mime.c:         && r->proxyreq == NOT_PROXY) {
> | mod_rewrite.c:            r->proxyreq = 1;
> | mod_rewrite.c:            r->proxyreq = 1;
> | mod_speling.c:    if (r->proxyreq || (r->finfo.st_mode != 0)) {
> 
> Although it still works because of the enum's actual values, mod_digest,
> mod_speling and mod_rewrite should be updated, too. At least I find it
> unclean to use an enum value still in a boolean context.

Indeed. I designed it so that third-party modules would continue to
work, and this applies equally to the ones I missed. They should be
fixed, of course.

Cheers,

Ben.

--
SECURE HOSTING AT THE BUNKER! http://www.thebunker.net/hosting.htm

http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi

Mime
View raw message