httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@Mch.SNI.De>
Subject Re: cvs commit: apache-1.3/src Configure
Date Mon, 10 Jan 2000 22:37:59 GMT
On Mon, Jan 10, 2000 at 07:30:43AM -0500, Jim Jagielski wrote:
> I don't think we use this construct anyplace else... Being so
> close to 1.3.10, this makes me a little nervous :)

It's alright (this branch is really only executed on BS2000).

> Is it OK if I switch that to:
> 
> 	ISSR2000="`bs2cmd SHOW-SYSTEM-INFO | grep 'HSI-ATT.*TYPE.*SR'`"
> 	case "$ISSR2000" in
> 	   *HSI-ATT.*TYPE.*SR*)
> 	      CFLAGS="$CFLAGS -Krisc_4000"
> 	      ;;
> 	esac

Yes, would be fine with me just as well. I simply copied over the other
"if" from perl and did not think of the test [ -n ... ], sorry.

> PS: Not sure what the output is of bs2cmd SHOW-SYSTEM-INFO but we
>     could drop that grep as well I'm thinking, unless it's multi-line
>     in which case the grep kinda makes sense.

Yes, it's about 20 lines.
But: good point (I dislike the heavy use of grep too).

Change as you feel fit. But to the best of my knowledge ;-) this shouldn't
have hurt any other platform.

    Martin
-- 
  <Martin.Kraemer@MchP.Siemens.De>      |       Fujitsu Siemens
       <martin@apache.org>              |   81730  Munich,  Germany

Mime
View raw message