httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_actions.c mod_asis.c mod_autoindex.c mod_cgi.c mod_dir.c mod_include.c mod_mime.c mod_negotiation.c mod_userdir.c
Date Sun, 09 Jan 2000 07:25:19 GMT
On 6 Jan 2000 14:43:52 -0000, rbb@hyperreal.org wrote:

>rbb         00/01/06 06:43:51
>
>  Modified:    src/include httpd.h
>               src/lib/apr/file_io/unix fileacc.c filedup.c fileio.h
>                        filestat.c open.c pipe.c readwrite.c
>               src/lib/apr/include apr_file_io.h
>               src/lib/apr/test ab_apr.c testmmap.c
>               src/main http_config.c http_core.c http_log.c
>                        http_protocol.c http_request.c util.c
>               src/modules/standard mod_actions.c mod_asis.c
>                        mod_autoindex.c mod_cgi.c mod_dir.c mod_include.c
>                        mod_mime.c mod_negotiation.c mod_userdir.c
>  Log:
>  Separate the stat structure from the file structure and use ap_stat and
>  ap_getfileinfo in apache.
>  
>  Revision  Changes    Path

[...]

>  1.26      +20 -9     apache-2.0/src/lib/apr/include/apr_file_io.h
>  
>  Index: apr_file_io.h
>  ===================================================================
>  RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr_file_io.h,v
>  retrieving revision 1.25
>  retrieving revision 1.26
>  diff -u -r1.25 -r1.26
>  --- apr_file_io.h	2000/01/04 19:00:44	1.25
>  +++ apr_file_io.h	2000/01/06 14:43:19	1.26

[...]

>  -ap_status_t ap_get_filetype(ap_filetype_e *, ap_file_t *);
>  +ap_status_t ap_get_filetype(ap_filetype_e *, ap_fileperms_t);

This API change is not right. It assumes a file's type can be derived from a
ap_fileperms_t which is not true for all platforms, probably only true for
unix. The OS/2 implementation of ap_get_filetype() needs the file handle.

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message