httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: [PATCH] vhost hostname in scoreboard not useful when using
Date Wed, 05 Jan 2000 00:53:14 GMT
Cliff Woolley wrote:
> 
> >>> "Cliff Woolley" <jwoolley@wlu.edu> 01/04/00 06:58PM >>>
> 
> >>This patch is, mainly, for those interested enough in speed
> >>and lean to have mod_vhost_alias installed yet not so concerned
> >>that they are running with full mod_status stats :)
> >Or for those who could care less about speed and leanness but who
> like
> >the simplicity of configuration with mod_vhost_alias and like to see
> the
> >ExtendedStatus.  True.
> 
> Time out now.  Would you then say it's safe to assume that it the user
> chooses ExtendedStatus on then we can ignore the speed/leanness concern
> and go ahead and save the hostname, since we're basically doing all that
> work of populating those fields for human-readable content anyway?
> 
> In other words, what if the patch were changed s.t. it was more like:
> 
> 1) add the hostname back into the short_score
> 2) make the change to http_main.c to populate ss->hostname, but only do
> it if ExtendStatus is on
> 3) in mod_status, if the ss->hostname has a value, use it, otherwise,
> use the vhost->hostname...
> 
> Does that sound reasonable?  I can live with that.  After all, all of
> this makes little sense unless ExtendedStatus is on anyway.
> 

That's the way it is now. All that stuff is only done if ExtendedStatus
is on.

Also, using static strings, we don't even _need_ that vhost struct
stuff.
-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
                "Are you suggesting coconuts migrate??"

Mime
View raw message