httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Harris" <dhar...@drh.net>
Subject RE: [PATCH] mod_autoindex - new feature: UseTable
Date Thu, 06 Jan 2000 19:08:54 GMT

Matthias Eckermann wrote:
> << File: mod_autoindex-1.3.dif3 >> Hi,
>
> the attached patch adds the option "UseTable" to mod_autoindex.
> The patch is against the latest CVS (as of 20000106) of 1.3.10-dev.
>
> I changed "mod_autoindex.c" and "mod_autoindex.html".
>
> Hope, it's helpful.
>
> Best regards
>		Matthias Eckermann

I think there are some problems with how the table created by this patch is
defined by a stylesheet.

This patch makes the emit_preamble code print out a <style>..</style> section
which re-defines styles for the "table", "td", and "a" HTML elements. There are
two problems with this when you consider a HEADER.html file being included.

(a) If the SuppressHTMLPreamble option is true, then you loose the formatting
on the table because the stylesheet is never printed.

(b) If the SuppressHTMLPreamble option is false, then you screw with the look
of the HEADER.html file because you have re-defined the look of some common
HTML elements. (The <style>..</style> section from emit_preamble will be
printed before the HEADER.html file.)

Problem B can be solved by using classes and not touching the definitions of
the standard HTML tags. For example, change "table" to "table.autoindex" in the
stylesheet and use a class=autoindex in the appropriate table tag. I'm not sure
how problem A could be solved.

Here is an example of a real-life HEADER.html setup that could get destroyed by
problem B:

http://www.engelschall.com/sw/str/
http://www.engelschall.com/sw/str/HEADER.html

 - David Harris
   Principal Engineer, DRH Internet Services



Mime
View raw message