Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 12400 invoked by uid 6000); 7 Dec 1999 20:54:18 -0000 Received: (qmail 12173 invoked by uid 24); 7 Dec 1999 20:54:07 -0000 Received: (qmail 25208 invoked from network); 7 Dec 1999 13:02:42 -0000 Received: from smtp.ntrnet.net (206.66.160.16) by taz.hyperreal.org with SMTP; 7 Dec 1999 13:02:42 -0000 Received: from mail.ntrnet.net (mail.ntrnet.net [206.66.160.4]) by smtp.ntrnet.net (Postfix) with ESMTP id 96A931F035 for ; Tue, 7 Dec 1999 08:02:41 -0500 (EST) Received: from shell.ntrnet.net (squid.ntrnet.net [206.66.160.7]) by mail.ntrnet.net (Postfix) with ESMTP id 71A2576806 for ; Tue, 7 Dec 1999 08:02:41 -0500 (EST) Received: (from rbb@localhost) by shell.ntrnet.net (8.8.5/8.8.5) id IAA15011; Tue, 7 Dec 1999 08:02:40 -0500 Date: Tue, 7 Dec 1999 08:02:40 -0500 (EST) From: rbb@apache.org X-Sender: rbb@shell.ntrnet.net To: new-httpd@apache.org Subject: Re: cvs commit: apache-2.0/src/lib/apr/threadproc/unix thread.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org Status: O On Mon, 6 Dec 1999, Greg Stein wrote: > > Cleanup some mistakes I made. We are now configuring the APR_HAS_FOO > > macros in a cleaner way IMO, and that required that we always use #if > > instead of #ifdef. I also used the wrong #if HAVE_SIGNAL_H macro > > in apr_pools.c. > > This seems very wrong, to me. We just got done having a discussion that we > would be using the #ifdef variety for feature testing. I do not think we > ought to be using #ifdef for autoconf tests, but #if for APR tests. We are > sure to run into a confusion somewhere and have unexpected results. > > Why can't we use #ifdef for APR, too? Because of the separation that autoconf requires. This code is MUCH cleaner for the configuration. I can define shell variables to be 0/1 or I can define them to be "#define APR_HAS_THREADS 1"/"#under APR_HAS_THREADS", and then substitute those shell variables into a header file. The first case is easier to understand when you look at the pre-generated header file. I personally believe Apache will end up heading this way as well, because it will need to do the same basic steps as I have already done to get the separation required. Ryan _______________________________________________________________________________ Ryan Bloom rbb@ntrnet.net 6209 H Shanda Dr. Raleigh, NC 27609 Ryan Bloom -- thinker, adventurer, artist, writer, but mostly, friend. -------------------------------------------------------------------------------