httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr Makefile.in
Date Tue, 21 Dec 1999 21:13:31 GMT
On Tue, 21 Dec 1999, Ryan Bloom wrote:
> > >    	@rm -f @LIBPREFIX@apr.a
> > >   +	@echo "===> Copying object files to objs directory"
> > >    	@for i in $(SUBDIRS); do cp $$i/*.o objs ; done;
> > >   +	@echo "<=== Done Copying files"
> > >   +	@echo "===> Creating unified library"
> > >    	@$(AR) cr @LIBPREFIX@apr.a objs/*.o
> > >   +	@echo "<=== Library built"
> > 
> > Why not just remove some of those "@" from the make? A bit simpler, me
> > thinks :-)
> 
> Because when I don't have the @ in front of the echo, it looks like:
> 
> echo "===> Copying object ..."
> ===> Copying object...
> 
> In other words, we get the echo command echoed, and then we see what was
> echoed.  The other @ are in there for other platforms I am assuming.

Not the echo, you silly :-)

I meant things like the "for" or the $(AR). In other words, just display
that... the builder understands you're "Creating unified library" when he
sees the "ar" get run. Replacing the command line with "Creating unified
library" just serves to hide what is happening in case a problem exists.
For example, what if the LIBPREFIX is wrong? They'll never see that. What
is $(SUBDIRS) doesn't include one of the directories? Oops! Too bad.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message