httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Whitmarsh <>
Subject Re: [PATCH] Re: Time to roll the 1.3.10 tarball
Date Tue, 14 Dec 1999 03:23:48 GMT
On Wed, 8 Dec 1999 10:20:11 -0500, you wrote:

>I am reviewing your patch now. Don't know much about mod_proxy so I cannot
>promise I can get this integrated. I'd like to geet some feedback from some
>of the other members first.
>A couple of suggestions:
>1. In general it is best not to submit patches that combine unrelated fixes.
>Submit seperate patches for each. Folks are more likely to review small
>easily understandable patches than large ones.
>2. Submit patches as unified diffs rather than context diffs (i.e., use
>diff -u). The developer's pages suggests using diff -C3, but that is only
>because unified diffs are not supported on all platforms.  Cygnus diff
>supports unified diffs.

Here are the broken out patches, in unified diff format

child_args.patch fixes a bug whereby options with spaces aren't passed
correctly to child processes

gc_fix.patch allows basic functioning of garbage collection under
windows but does not deal with the problem of garbage collection
occurring in the thread that is servicing a response

gc_thread.patch incorporates the changes in gc_fix.patch but also
spawns a separate thread for garbage collection

tls.patch allows the proxy module to be loaded dynamically under
windows 95.

All patches are relative to the 1.3.9 release.



David Whitmarsh

Sparkle Computer Co Ltd

Sybase C C++ perl UNIX NT


View raw message