httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@mch.sni.de>
Subject Re: [PATCH]Apache 1.3.9 Port to OS/390 Unix System Services -- The Basics -- cleaned up
Date Tue, 07 Dec 1999 22:21:44 GMT
Much better. Thanks a lot!

On Tue, Dec 07, 1999 at 04:24:23PM -0800, Ovies Brabson wrote:
> Index: apache-1.3/Makefile.tmpl
> ===================================================================
> RCS file: /home/cvs/apache-1.3/Makefile.tmpl,v
> retrieving revision 1.93
> diff -u -b -r1.93 Makefile.tmpl
> --- Makefile.tmpl	1999/12/02 21:00:19	1.93
> +++ Makefile.tmpl	1999/12/07 21:08:47
> @@ -176,11 +179,17 @@
>  
>  #   build the standard stuff
>  build-std:
> -	@cd $(TOP)/$(SRC); $(MAKE) $(MFLAGS) SDP=$(SRC)/ all
> +	case "x$(PLATFORM)" in \
> +	  x*390*) _C89_STEPS="0xffffffff"; export _C89_STEPS;; \
> +	esac; \
> +	cd $(TOP)/$(SRC); $(MAKE) $(MFLAGS) SDP=$(SRC)/ all

I would use
> +     @case "x$(PLATFORM)" in \
   ...
because the intention was to not print the make line. Without
the '@', all four lines are printed, clobbering the screen.

> Index: apache-1.3/configure
> ===================================================================
> RCS file: /home/cvs/apache-1.3/configure,v
> retrieving revision 1.112
> diff -u -b -r1.112 configure
> --- configure	1999/12/07 14:14:59	1.112
> +++ configure	1999/12/07 21:08:47
> @@ -134,6 +134,47 @@
>  fi
>  
>  ##
> +## Check if this is a release of OS/390 prior to V2R8.  If it
> +## is warn user that cgi scripts may not work unless
> +## NEED_HASHBANG_EMUL is defined.  This piece of code will
!? This can all be deleted now, since I committed the
ap_execve.c cast patch today. I still propose to leave the
switch NEED_HASHBANG_EMUL defined for ALL releases of OS390.

> +        --server-uid=*)
> +            conf_user="$apc_optarg"
> +            ;;

I was dreaming of something along the line of...
> +        --server-uid=*)
> +            conf_user="$apc_optarg"
> +            # protect the '#' against interpretation as comment
> +            case x"${conf_user}" in
> +              "#"*)  conf_user="\\\\${conf_user}";;
> +              "\\#"*)conf_user="\\${conf_user}";;
> +            esac
> +            ;;
...and dito for conf_group.

> Index: apache-1.3/src/helpers/binbuild.sh
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/helpers/binbuild.sh,v
> retrieving revision 1.13
> diff -u -b -r1.13 binbuild.sh
> --- binbuild.sh	1999/08/13 03:26:29	1.13
> +++ binbuild.sh	1999/12/07 21:08:47
> @@ -269,7 +271,15 @@
>    else
>      if [ "x$TAR" != "x" ]
>      then
> +      if echo "$OS" | grep -q '390'; then
> +        $TAR -cfU ../apache_$VER-$OS.tar -C .. apache_$VER
> +      else
>        $TAR -cf ../apache_$VER-$OS.tar -C .. apache_$VER
> +      fi
> +      case "x$OS" in
> +        x*390) $TAR -cfU ../apache_$VER-$OS.tar -C .. apache_$VER;;
> +	    *) $TAR -cf ../apache_$VER-$OS.tar -C .. apache_$VER;;
> +      esac

Ahem... This is duplicate, isn't it? Probably, the 5 lines starting
at ..."grep -q"... should be deleted.

> Index: apache-1.3/src/include/ap_config.h
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/include/ap_config.h,v
> retrieving revision 1.277
> diff -u -b -r1.277 ap_config.h
> --- ap_config.h	1999/12/07 12:19:50	1.277
> +++ ap_config.h	1999/12/07 21:08:48
> @@ -946,6 +946,28 @@
>  #define NO_KILLPG
>  #define NEED_INITGROUPS
>  #define NO_SLACK
> +
> +#elif defined(OS390)                /* IBM OS/390 Operating System      */
> +#define HAVE_MMAP
> +#define HAVE_SHMGET
> +#define USE_SHMGET_SCOREBOARD
> +#define USE_MMAP_FILES
> +#define USE_FCNTL_SERIALIZED_ACCEPT

and probably HAVE_HASHBANG_EMUL ?


Cheers,
	Martin
-- 
<Martin.Kraemer@MchP.Siemens.De>             |    Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-41143 | 81730  Munich,  Germany

Mime
View raw message