httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sascha Schumann <>
Subject Re: [PATCH]
Date Tue, 07 Dec 1999 11:15:13 GMT
On Tue, Dec 07, 1999 at 01:51:28AM -0500, Manoj Kasichainula wrote:
> The attached patch gets rid of a minor hack that I stole from PHP4,
> and replaces it with a somewhat more major hack. Please comment on it,
> especially you PHP guys who wrote the original hack. Please cc: the
> php list if you think this is appropriate, since PHP could make a
> similar change.

    We had exactly this approach before. We dropped it because
    always generating all ext/*/Makefiles does take a lot of time
    (we are at ~50 extensions). automake is wrong, because it
    assumes a static list of filenames in AC_OUTPUT.
> Right now, the AC_OUTPUT() line in includes a variable
> ($APACHE_OUTPUT_FILES).  Automake doesn't know how to deal with this,
> and probably won't anytime soon, because knowing the value of
> $APACHE_OUTPUT_FILES requires running ./configure. So Automake
> complains, and a couple of things are broken.

    First, automake's warning are generally useless (because they
    are based on too narrow assumptions). Having one more useless
    warning hardly bothers me. 

    Second, this does not affect the normal use of the build
    environment. There are some issues in maintainer mode, but
    the effects encountered there are bearable and limited to
    maintainers (aka developers).

> With this, the in PHP4 shouldn't be necessary, because
> automake seems to know how to handle all that stuff. make dist almost
> works (and I think it can work completely in the Apache tree once I
> fix a few errors I made).

    Wrong. does a lot more (i.e. checking tool versions,
    running only the required set of tools, preserving our custom
    libtool files, et cetera). 



                            Sascha Schumann

View raw message