httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From p.@sweng.stortek.com
Subject Re: OS/390 Translation
Date Sat, 04 Dec 1999 18:18:15 GMT
In a recent note, Jim Jagielski said:

> Date: Sat, 4 Dec 1999 08:49:14 -0500 (EST)
> 
> Martin Kraemer wrote:
> > On Fri, Dec 03, 1999 at 03:55:23PM -0700, pg@sweng.stortek.com wrote:
> > > How about something like the attached (submitted for discussion,
> > > -                ap_rvputs(r, "\015\012--", r->boundary, "--\015\012", NULL);
> > > +                ap_rvputs(r, CRLF"--", r->boundary, "--"CRLF, NULL);
> > 
> > Not bad. I like the idea.
> Me too :)
> 
What's the likely impact on non-ANSI compilers that lack compile-time
string abutment, but otherwise support Apache httpd?

How do I isolate instances that need to be left alone.  In cases (as
above) where the CR and LF are incorporated in strings containing other
text, the intent is pretty clear, but what about:

    src/modules/proxy/proxy_ftp.c:  if (ch == '\015' || ch == '\012' || (ch & 0x80))
    src/main/rfc1413.c:    while((cp = strchr(buffer, '\012')) == NULL && i < sizeof(buffer)
- 1) {

for example?  These have already been caught and fixed, but are there others?

There are really only about three dozen instances of 012 in the source:

    pg@sanitas:150$ grep 012[^3] `find src ! -name ebcdic.c` | wc
          35     251    2692

a third in http_protocol.c, a third in buff.c, the rest scattered.  (I
discounted ebcdic.c -- it's a victim rather than a perpetrator.)

-- gil
-- 
StorageTek
INFORMATION made POWERFUL

Mime
View raw message