httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <stodd...@raleigh.ibm.com>
Subject Re: [PATCH] Re: Time to roll the 1.3.10 tarball
Date Wed, 08 Dec 1999 15:20:11 GMT
David,
I am reviewing your patch now. Don't know much about mod_proxy so I cannot
promise I can get this integrated. I'd like to geet some feedback from some
of the other members first.

A couple of suggestions:
1. In general it is best not to submit patches that combine unrelated fixes.
Submit seperate patches for each. Folks are more likely to review small
easily understandable patches than large ones.

2. Submit patches as unified diffs rather than context diffs (i.e., use
diff -u). The developer's pages suggests using diff -C3, but that is only
because unified diffs are not supported on all platforms.  Cygnus diff
supports unified diffs.

Bill


Mime
View raw message