Date: Wed, 10 Nov 1999 13:08:53 -0500 (EST)
From: Ryan Bloom <rbb@raleigh.ibm.com>
To: new-httpd@apache.org
Subject: Re:  Common code
Message-ID: 
 <Pine.LNX.4.04.9911101302100.14299-100000@chosondo.raleigh.ibm.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org


I think I like the idea of #ifdef's actually.  It tells the programmer
exactly which header file they should be modifying.  I considered doing
this in the Makefile, by using "-I../@OSDIR@" instead of "-I.".  But I
think this is just confusing, and it just ends up hiding where the file is
really located.

I'm +1 for the ifdefs.

Ryan

> OK, so I'm revisiting this (yet) again.
>
> The recent addition of sockaddr.c meant that I had an opportunity to
> practise what I preach and use the default.c file to include the code.
> Problem I discovered is that it uses the networkio.h from the Unix
> directory, not the beos one!  There isn't much difference but enough to
> provoke a few memory faults.  It can easily overcome by a small #ifdef
> but
> does that defeat the objective of having nice clean code?
>
> I've committed a sockaddr.c into the beos directory until this is
> resolved...
>
>david

_______________________________________________________________________
Ryan Bloom		rbb@raleigh.ibm.com
4205 S Miami Blvd	
RTP, NC 27709		It's a beautiful sight to see good dancers 
			doing simple steps.  It's a painful sight to
			see beginners doing complicated patterns.