From: Jim Jagielski <jim@devsys.jaguNET.com>
Message-Id: <199911301356.IAA28363@devsys.jaguNET.com>
Subject: Re: cvs commit: apache-2.0/src/os/win32 os.h
To: new-httpd@apache.org
Date: Tue, 30 Nov 1999 08:56:51 -0500 (EST)
In-Reply-To: <19991130085258.A13954@engelschall.com> from "Ralf S.
 Engelschall" at Nov 30, 1999 08:52:58 AM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

Ralf S. Engelschall wrote:
> 
> 
> In article <199911292340.SAA23322@devsys.jaguNET.com> you wrote:
> > manoj@hyperreal.org wrote:
> >> 
> >>   Log:
> >>   The first part of the big autoconf patch. This replaces a bunch of
> >>   NEED_* macros with HAVE_* macros to be more consistent with autoconf.
> >>   
> >>   -#ifdef NEED_STRDUP
> >>   +#ifndef HAVE_STRDUP
> >>    char *strdup(const char *str)
> >>    {
> >>        char *sdup;
> > 
> > Is this quite right? Isn't the "right" way to have
> > 
> > 	#if HAVE_STRDUP
> 
> No, #ifndef HAVE_STRDUP is correct Autoconf-style. One tests only for the
> symbol defined or not. That's the usual style in Autoconf.
> 

I've seen it both ways in autoconf systems, and autoconf itself
will, IIRC, allow and maintain both. In fact, doesn't PHP4 use
the #if HAVE_FOOBAR method?

-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
                "Are you suggesting coconuts migrate??"