Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 2522 invoked by uid 6000); 11 Nov 1999 05:36:20 -0000 Received: (qmail 2511 invoked from network); 11 Nov 1999 05:36:17 -0000 Received: from smtp6.mindspring.com (207.69.200.110) by taz.hyperreal.org with SMTP; 11 Nov 1999 05:36:17 -0000 Received: from samosa.manoj.nonet (user-2ivf18f.dialup.mindspring.com [165.247.133.15]) by smtp6.mindspring.com (8.8.5/8.8.5) with ESMTP id AAA29796 for ; Thu, 11 Nov 1999 00:36:11 -0500 (EST) Received: by samosa.manoj.nonet (Postfix, from userid 500) id 0B4D456855; Thu, 11 Nov 1999 00:35:51 -0500 (EST) Date: Thu, 11 Nov 1999 00:35:51 -0500 From: Manoj Kasichainula To: new-httpd@apache.org Subject: Re: [PATCH] Whoops, here's the better Linux senfile() Message-ID: <19991111003550.A30656@samosa.mindspring.com> Mail-Followup-To: new-httpd@apache.org References: <19991104171743.A1447@dosa.raleigh.ibm.com> <3823B9D1.576DBCB0@princeton.edu> <000d01bf2818$fb09c1b0$a78fe120@raleigh.ibm.com> <38252A80.DD304A88@princeton.edu> <382533FF.EB7F121B@princeton.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii User-Agent: Mutt/1.1.1i In-Reply-To: <382533FF.EB7F121B@princeton.edu>; from zedlwski@Princeton.EDU on Sun, Nov 07, 1999 at 03:10:39AM -0500 Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org First, I'd suggest sending diffs to the list instead. See . Since you're using Linux, use "diff -u" instead of "diff -C3" to get unified diffs; they're much prettier. The patch looks great. It covers everything I wanted to see when I thought about writing it. :) I'll test it a bit and hopefully commit it tomorrow. I like TCP_CORK though, so I want to uncomment those setsockopts. Hopefully, we can put this into APR at some point. -- Manoj Kasichainula - manojk at io dot com - http://www.io.com/~manojk/