httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <>
Subject Re: [PATCH] ap_sendfile try #1
Date Fri, 12 Nov 1999 10:10:48 GMT
On Fri, 12 Nov 1999, John Zedlewski wrote:
> Well, here's an initial look at an implementation for ap_sendfile in the Unix
> APR.  I work on Linux, but I also wrote (untested) versions for the HP-UX and
> FreeBSD APIs so I could see how different they'd be.  Currently, the three
> OS-specific versions are completely separate.  What will be the neatest way to
> format these eventually?

Uh oh.. don't go there... :-)

We had this "discussion" a while back on the list. Some people said to
share the function definition and #ifdef the interior contents; others
said to #ifdef the entire function (including the definition line(s)).

I think the end result was "whoever implements the code will use their
preferred pattern, but people can always go through and retrofit if it
spins their bottle."

About the patch you attached. Couple things:
1) there is a lot of extraneous, unrelated stuff that appears to be a diff
   caused by formatting/spacing differences. That should be removed from
   the patch so that it is easier to look at the "real" change.
2) the patch is reversed. All your changes have "-" in front of them,
   rather than adding the lines :-)


Greg Stein,

View raw message