httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <>
Subject Re: Yet another discussion and [PATCH] for ap_sendfile
Date Mon, 22 Nov 1999 15:34:07 GMT
> I general, I like this patch.  I am re-posting it, because I have cleaned
> up the formating a bit.  Took out some tabs, and re-generated it against
> the tree from CVS.  I added a few commands to autoconf to get
> HAVE_SENDFILE defined for us.  I also added the APR_HAS_SENDFILE #define.
> It is defined at the same time as HAVE_SENDFILE, but APR_HAS_SENDFILE
> makes sense on platforms like Windows, which doesn't have autoconf.  It is
> an APR feature macro, and I am trying to get those into place now.  :-)

Oh, I also changed a parameter name.  I am trying VERY hard not to name
variables the same name as a C Run-Time function.  That's why all the old
ap_socket_t *socket 's have been renamed to ap_socket_t *sock.


Ryan Bloom
4205 S Miami Blvd	
RTP, NC 27709		It's a beautiful sight to see good dancers 
			doing simple steps.  It's a painful sight to
			see beginners doing complicated patterns.	

View raw message