httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: Duplicate code.
Date Fri, 19 Nov 1999 18:47:49 GMT
Ryan Bloom wrote:
> 
> We have a real problem with duplicate code between MPM's.  I am currently
> changing the fprintf's to ap_log_error's within the MPM's, and what I keep
> seeing, is the same error message surrounded by the same if statements in
> the same functions in EVERY MPM directory.
> 
> The scoreboard and accept locking code seem to be the biggest offenders,
> but they are by no means the only offenders.  Can we PLEASE do something
> to get the common code together in a single file.  I would personally
> suggest ripping the scoreboard and acceptlock files out of either dexter
> or mpmt_pthread, and moving it to src/main.  Then, remove all of the
> duplicated code, and use the functions that are provided in the files that
> we just moved.  I REALLY think MPM's need to be MUCH smaller than they are
> now.

Surely (most of) the accept locking should be in APR? Since it is just a
generic mutex?

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi

Mime
View raw message