httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manoj Kasichainula <man...@io.com>
Subject Re: cvs commit: apache-2.0/src/os/win32 os.h
Date Tue, 30 Nov 1999 02:01:48 GMT
On Mon, Nov 29, 1999 at 07:46:28PM -0500, Jim Jagielski wrote:
> Manoj Kasichainula wrote:
> > What happens when you "#if HAVE_STRDUP" and HAVE_STRDUP is not
> > defined? If the compiler blows up, then we should leave things the way
> > they are.
> 
> Agreed, that's why I said that we need to make sure that for
> every preprocessor variable we use, we would need to make sure
> it's 0 or 1. Of course, doing this forces us to make sure that's
> that case or else the compiler/preprocessor will barf (good for
> finding typos).

This is the problem. :) It's really really helpful to use autoheader
to generate ap_config_auto.h.in. And autoheader uses #define/#undef.

It's not a big deal anyway. If someone pipes up and says that
compilers can stand it, it's easy to change later if we want.

-- 
Manoj Kasichainula - manojk at io dot com - http://www.io.com/~manojk/

Mime
View raw message