httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@devsys.jaguNET.com>
Subject Re: cvs commit: apache-1.3/src/ap ap_snprintf.c
Date Sun, 28 Nov 1999 15:22:40 GMT
rse@hyperreal.org wrote:
> 
> rse         99/11/28 05:51:54
> 
>   Index: ap_snprintf.c
>   ===================================================================
>   RCS file: /e/apache/REPOS/apache-1.3/src/ap/ap_snprintf.c,v
>   retrieving revision 1.37
>   diff -u -r1.37 ap_snprintf.c
>   --- ap_snprintf.c   1999/10/21 20:44:10 1.37
>   +++ ap_snprintf.c   1999/11/17 12:22:11
>   @@ -414,7 +413,7 @@
>         * If the value is less than the maximum unsigned long value,
>         * then we know we aren't using quads, so use the faster function
>         */
>   -    if (num <= ULONG_MAX)
>   +    if (num <= ULONG_MAX && is_unsigned)
>           return(conv_10( (wide_int)num, is_unsigned, is_negative,
>              buf_end, len));
>   

This doesn't seem quite right to me. This means that if the number is
signed, that the faster conv_10 function will never be used.

I'll look into this.
-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
                "Are you suggesting coconuts migrate??"

Mime
View raw message