httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manoj Kasichainula <man...@io.com>
Subject Re: [PATCH] for indexing problem in 1.3.9 mod_autoindex module.
Date Wed, 03 Nov 1999 08:07:00 GMT
untested, but it seems reasonable (yet another module I don't mess
with, though). I'm curious about one thing, though:

On Wed, Oct 27, 1999 at 02:28:10PM +0530, Jayaram A wrote:
> --- 1312,1321 ----
>   
>       if (autoindex_opts & FANCY_INDEXING) {
>   	ap_rputs("<PRE>", r);
> !     if ((tp = find_default_icon(d, "^^BLANKICON^^")) &&
> !         (altp = find_default_alt(d, "^^BLANKICON^^"))) {
> !         ap_rvputs(r, "<IMG SRC=\"", ap_escape_html(scratch, tp),
> !            "\" ALT=\"[", (altp ? altp : "   "), "]\"",  NULL);

Doesn't altp have to be nonnull here, because of the if statement?
Then the altp ? altp :  "   " shouldn't be necessary, or am I missing
something?

-- 
Manoj Kasichainula - manojk at io dot com - http://www.io.com/~manojk/

Mime
View raw message