httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manoj Kasichainula <man...@io.com>
Subject Re: [PATCH] for PR# 4856 : problem with 1.3.9 mod_env module.
Date Wed, 03 Nov 1999 07:53:47 GMT
On Wed, Oct 27, 1999 at 02:41:17PM +0530, Jayaram A wrote:
> Please comment on the below fix the problem in mod_env module.

I don't know this module at all, but the patch seems okay to me.

BTW, please use unified diffs if you can. I know dev.apache.org says
to use -C3, but that's because many diff tools don't support -u.

> +     if ( base->unsetenv ) {
> +         new->unsetenv = (char *)ap_palloc(p, strlen(base->unsetenv)+1);
> +         memcpy(new->unsetenv, base->unsetenv, strlen(base->unsetenv)+1);
> +     } else
> +         new->unsetenv = "";
> + 

I guess this hunk fixes a problem where unsetenvs aren't inherited but
setenvs are?

-- 
Manoj Kasichainula - manojk at io dot com - http://www.io.com/~manojk/

Mime
View raw message