httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manoj Kasichainula <man...@raleigh.ibm.com>
Subject Re: cvs commit: apache-2.0/src/main http_protocol.c
Date Mon, 01 Nov 1999 19:33:41 GMT
On Mon, Nov 01, 1999 at 10:50:49AM -0000, bjh@hyperreal.org wrote:
>   In ap_send_fb_length() don't treat APR_EOF as a fatal error.

Hmmm, I was under the impression that we didn't really use APR_EOF in
many places. The buff stuff I've done assumed that EOF would be
indicated with a zero length read and APR_SUCCESS.

It appears that OS/2's APR code uses APR_EOF in ap_read and ap_write,
while Unix's does not. One standard should be chosen.

I'm not a big fan of APR_EOF in these cases because it makes checking
for "success" more complicated. 

-- 
Manoj Kasichainula - manojk@raleigh.ibm.com
IBM, Apache Development

Mime
View raw message