httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <stodd...@raleigh.ibm.com>
Subject Re: [PATCH] NT signal problem
Date Wed, 03 Nov 1999 14:51:07 GMT
Cool. This will fix at least one PR.

Bill
----- Original Message -----
From: Keith Wannamaker <krw@raleigh.ibm.com>
To: <new-httpd@apache.org>
Sent: Tuesday, November 02, 1999 5:45 PM
Subject: [PATCH] NT signal problem


> At one time the assumption we made about
> InitSecurityDescriptor was true,
> but on NT 4/SP 5 this is not the case.
> It's safer to set the last error beforehand.
>
> Without this,
> net start apache
> apache -k shutdown
> is broken.
>
> --
> Keith Wannamaker
> IBM HTTP Server Development
> RTP NC, USA


----------------------------------------------------------------------------
----


> --- \apache-1.3-cvs\src\main\http_main.c Fri Oct 29 08:47:57 1999
> +++ src\main\http_main.c Tue Nov 02 22:37:19 1999
> @@ -6239,10 +6239,9 @@
>          return NULL;
>      }
>      /*
> -     * We can safely use GetLastError() here without presetting it;
> -     * {Initialize,Set}SecurityDescriptor() have been verified as
clearing it
> -     * on successful completion.
> +     * Win98 returns nonzero on failure; check LastError to make sure.
>       */
> +    SetLastError(0);
>      if (!InitializeSecurityDescriptor(pSD, SECURITY_DESCRIPTOR_REVISION)
>   || GetLastError()) {
>          LocalFree( pSD );
>


Mime
View raw message