Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 15474 invoked by uid 6000); 13 Oct 1999 21:28:40 -0000 Received: (qmail 15409 invoked from network); 13 Oct 1999 21:28:36 -0000 Received: from smtp.ntrnet.net (206.66.160.16) by taz.hyperreal.org with SMTP; 13 Oct 1999 21:28:36 -0000 Received: from mail.ntrnet.net (mail.ntrnet.net [206.66.160.4]) by smtp.ntrnet.net (Postfix) with ESMTP id C11D01F035; Wed, 13 Oct 1999 17:32:41 -0400 (EDT) Received: from shell.ntrnet.net (squid.ntrnet.net [206.66.160.7]) by mail.ntrnet.net (Postfix) with ESMTP id D1B6176806; Wed, 13 Oct 1999 17:28:33 -0400 (EDT) Received: (from rbb@localhost) by shell.ntrnet.net (8.8.5/8.8.5) id RAA25881; Wed, 13 Oct 1999 17:28:33 -0400 Date: Wed, 13 Oct 1999 17:28:32 -0400 (EDT) From: Ryan Bloom To: new-httpd@apache.org Cc: apache-2.0-cvs@apache.org Subject: Re: cvs commit: apache-2.0/src/lib/apr/include apr_file_io.h In-Reply-To: <19991013203343.24497.qmail@hyperreal.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On 13 Oct 1999 bhyde@hyperreal.org wrote: > bhyde 99/10/13 13:33:43 > > Modified: src/lib/apr/include apr_file_io.h > Log: > Mr. -Wall, full of opinions. > > Revision Changes Path > 1.14 +1 -1 apache-2.0/src/lib/apr/include/apr_file_io.h > > Index: apr_file_io.h > =================================================================== > RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr_file_io.h,v > retrieving revision 1.13 > retrieving revision 1.14 > diff -u -r1.13 -r1.14 > --- apr_file_io.h 1999/10/13 15:29:18 1.13 > +++ apr_file_io.h 1999/10/13 20:33:42 1.14 > @@ -130,7 +130,7 @@ > API_EXPORT(int) ap_fprintf(ap_file_t *fptr, const char *format, ...) > __attribute__((format(printf,2,3))); > > -ap_status_t ap_make_iov(ap_iovec_t **, struct iovec *, ap_context_t *); > +ap_status_t ap_make_iov(ap_iovec_t **, ap_iovec_t *, ap_context_t *); This is wrong. There is no way somebody could have an ap_iovec_t to pass into this function as the second argument, because this function is creating the instance of ap_iovec_t. I'll fix it tomorrow. Ryan _______________________________________________________________________________ Ryan Bloom rbb@ntrnet.net 6209 H Shanda Dr. Raleigh, NC 27609 Ryan Bloom -- thinker, adventurer, artist, writer, but mostly, friend. -------------------------------------------------------------------------------