Date: Thu, 7 Oct 1999 08:56:37 -0400 (EDT)
From: Ryan Bloom <rbb@raleigh.ibm.com>
To: new-httpd@apache.org
Subject: Re: cvs commit: apache-2.0/src/lib/apr/time/unix time.c
In-Reply-To: <Pine.LNX.4.10.9910061828140.6085-100000@nebula.lyra.org>
Message-ID: <Pine.LNX.4.04.9910070837220.4619-100000@chosondo.raleigh.ibm.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

On Wed, 6 Oct 1999, Greg Stein wrote:

> Euh... it looks like this never stores a value back into lock_##func_name.
> Therefore, it will create a lock on every entry to the function.

Good catch.  This is the problem with making a lot of revisions to code, I
needed the re-direction one point, but now it's a bug.  Thanks, I'll fix
this ASAP.

> 
> Also, why are these macros in two places? acconfig.h and apr_config.h.in

Because apr_config.h.in is a generated file from autoheader.  It takes the
def from acconfig, and just throws it into apr_config.h.in.  It is
actually a really nice combination with autoheader and autoconf together.
I can still control what goes into apr_config.h.in, but if I add a new
function check in configure.in, autoheader finds it for me automatically.

> 
> Cheers,
> -g
> 
> --
> Greg Stein, http://www.lyra.org/
> 
> 
> 

_______________________________________________________________________
Ryan Bloom		rbb@raleigh.ibm.com
4205 S Miami Blvd	
RTP, NC 27709		It's a beautiful sight to see good dancers 
			doing simple steps.  It's a painful sight to
			see beginners doing complicated patterns.