Message-ID: <3801C177.AE5BE2F4@algroup.co.uk>
Date: Mon, 11 Oct 1999 11:52:39 +0100
From: Ben Laurie <ben@algroup.co.uk>
Organization: A.L. Group plc
MIME-Version: 1.0
To: new-httpd@apache.org
Subject: Re: cvs commit: apache-2.0/src/lib/apr/network_io/beos sockopt.c
References: <Pine.LNX.4.10.9910110155270.6085-100000@nebula.lyra.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

Greg Stein wrote:
> 
> Actually, I don't see how this could work. ap_pstrup() returns a char*. I
> don't see how you can cast that to a char** ...

That's exactly what I was about to say. This looks like nonsense to me!

> 
> (maybe Brian was saying the same thing but more diplomatically :-)

Diplomatic? What's that?

> On Sun, 10 Oct 1999, Brian Behlendorf wrote:
> > Is there a way to fix this without a cast?  Or is this a case where casts
> > are harmless?
> >
> >       Brian
> >
> > On 10 Oct 1999 dreid@hyperreal.org wrote:
> > > dreid       99/10/10 06:54:18
> > >
> > >   Modified:    src/lib/apr/network_io/beos sockopt.c
> > >   Log:
> > >   This stops a small moan by the compiler.
> > ...
> > >   -        *name = ap_pstrdup(sock->cntxt, hptr->h_name);
> > >   +        name = (char**)ap_pstrdup(sock->cntxt, hptr->h_name);
> >

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi