Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 17061 invoked by uid 6000); 11 Oct 1999 16:24:10 -0000 Received: (qmail 17051 invoked from network); 11 Oct 1999 16:24:08 -0000 Received: from server1.jetnet.co.uk (194.73.252.30) by taz.hyperreal.org with SMTP; 11 Oct 1999 16:24:08 -0000 Received: from godzilla (godzilla.jetnet.co.uk [192.168.26.10]) by server1.jetnet.co.uk (8.9.3/8.9.3) with SMTP id RAA50769 for ; Mon, 11 Oct 1999 17:23:03 +0100 (BST) Message-ID: <001901bf1404$e3019660$0a1aa8c0@jetnet.co.uk> From: "David Reid" To: References: <3801C177.AE5BE2F4@algroup.co.uk> Subject: Re: cvs commit: apache-2.0/src/lib/apr/network_io/beos sockopt.c Date: Mon, 11 Oct 1999 17:22:48 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2314.1300 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2314.1300 Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org Yeah well that'll teach me to use the code as a scratchpad whilst doing other things as well!! I corrected it in a later commit once I realised I'd let it slip through. Sorry :-( ----- Original Message ----- From: Ben Laurie To: Sent: 11 October 1999 11:52 Subject: Re: cvs commit: apache-2.0/src/lib/apr/network_io/beos sockopt.c > Greg Stein wrote: > > > > Actually, I don't see how this could work. ap_pstrup() returns a char*. I > > don't see how you can cast that to a char** ... > > That's exactly what I was about to say. This looks like nonsense to me! > > > > > (maybe Brian was saying the same thing but more diplomatically :-) > > Diplomatic? What's that? > > > On Sun, 10 Oct 1999, Brian Behlendorf wrote: > > > Is there a way to fix this without a cast? Or is this a case where casts > > > are harmless? > > > > > > Brian > > > > > > On 10 Oct 1999 dreid@hyperreal.org wrote: > > > > dreid 99/10/10 06:54:18 > > > > > > > > Modified: src/lib/apr/network_io/beos sockopt.c > > > > Log: > > > > This stops a small moan by the compiler. > > > ... > > > > - *name = ap_pstrdup(sock->cntxt, hptr->h_name); > > > > + name = (char**)ap_pstrdup(sock->cntxt, hptr->h_name); > > > > > Cheers, > > Ben. > > -- > http://www.apache-ssl.org/ben.html > > "My grandfather once told me that there are two kinds of people: those > who work and those who take the credit. He told me to try to be in the > first group; there was less competition there." > - Indira Gandhi