httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: cvs commit: apache-2.0/src/modules/mpm/winnt winnt.c
Date Thu, 07 Oct 1999 23:07:30 GMT
hmm... i haven't looked closely... but the reason malloc() was used was
because this info (the open fds) has to survive a configuration reload.  
i don't see how you achieve that...

Dean

On 7 Oct 1999 bhyde@hyperreal.org wrote:

> bhyde       99/10/07 13:48:29
> 
>   Modified:    src/include ap_listen.h http_config.h
>                src/main http_config.c http_main.c listen.c
>                src/modules/mpm/dexter dexter.c
>                src/modules/mpm/mpmt_pthread mpmt_pthread.c
>                src/modules/mpm/prefork prefork.c
>                src/modules/mpm/spmt_os2 spmt_os2.c
>                src/modules/mpm/winnt winnt.c
>   Log:
>   Well this was thought provoking.
>   
>   Drive out the use of malloc in two places.
>   
>   In listen.c, using the global process pool instead.  That changes the
>   API into listen so that a process is passed in rather than the config
>   pool.  That's all was easy.
>   
>   The pain is propogating a change into all N of the mpm, they
>   are all similar but different in their use of listen.c  There
>   is a lot to dislike about similar but code scattered code.
>   
>   I changed the N setup_listener routines, they now take only
>   the server since they can dig the config and global pool
>   out of there.
>   
>   Free today: ap_setup_prelinked_modules now takes the process so it
>   can allocate it's table in the process's pool rathern than use
>   malloc.


Mime
View raw message