httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@kiwi.ICS.UCI.EDU>
Subject Re: Thread safe functions in APR.
Date Wed, 06 Oct 1999 07:26:39 GMT
>#ifdef HAVE_GMTIME_R
>#define GMTIME_R(x, y) gmtime_r(x, y)
>#else
>#define GMTIME_R(x, y) memcpy(y, gmtime(x), sizeof(y))
>#endif

We can't use sizeof(y) unless we know that y is a struct and not a pointer,
which is not the case in the patch committed.  It is safer to define an
ap_gmtime with a single interface, and just change the implementation based
on whether gmtime_r is available.

....Roy

Mime
View raw message