httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Reid" <ab...@dial.pipex.com>
Subject Re: cvs commit: apache-2.0/src/lib/apr/network_io/beos sockopt.c
Date Mon, 11 Oct 1999 16:22:48 GMT
Yeah well that'll teach me to use the code as a scratchpad whilst doing
other things as well!!

I corrected it in a later commit once I realised I'd let it slip through.

Sorry :-(

----- Original Message -----
From: Ben Laurie <ben@algroup.co.uk>
To: <new-httpd@apache.org>
Sent: 11 October 1999 11:52
Subject: Re: cvs commit: apache-2.0/src/lib/apr/network_io/beos sockopt.c


> Greg Stein wrote:
> >
> > Actually, I don't see how this could work. ap_pstrup() returns a char*.
I
> > don't see how you can cast that to a char** ...
>
> That's exactly what I was about to say. This looks like nonsense to me!
>
> >
> > (maybe Brian was saying the same thing but more diplomatically :-)
>
> Diplomatic? What's that?
>
> > On Sun, 10 Oct 1999, Brian Behlendorf wrote:
> > > Is there a way to fix this without a cast?  Or is this a case where
casts
> > > are harmless?
> > >
> > >       Brian
> > >
> > > On 10 Oct 1999 dreid@hyperreal.org wrote:
> > > > dreid       99/10/10 06:54:18
> > > >
> > > >   Modified:    src/lib/apr/network_io/beos sockopt.c
> > > >   Log:
> > > >   This stops a small moan by the compiler.
> > > ...
> > > >   -        *name = ap_pstrdup(sock->cntxt, hptr->h_name);
> > > >   +        name = (char**)ap_pstrdup(sock->cntxt, hptr->h_name);
> > >
>
> Cheers,
>
> Ben.
>
> --
> http://www.apache-ssl.org/ben.html
>
> "My grandfather once told me that there are two kinds of people: those
> who work and those who take the credit. He told me to try to be in the
> first group; there was less competition there."
>      - Indira Gandhi


Mime
View raw message