Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 268 invoked by uid 6000); 3 Sep 1999 09:37:03 -0000 Received: (qmail 258 invoked from network); 3 Sep 1999 09:37:01 -0000 Received: from kurgan.lyra.org (root@208.192.43.9) by taz.hyperreal.org with SMTP; 3 Sep 1999 09:37:01 -0000 Received: from kurgan.lyra.org (IDENT:gstein@localhost [127.0.0.1]) by kurgan.lyra.org (8.9.2/8.9.2) with SMTP id CAA24022 for ; Fri, 3 Sep 1999 02:29:55 -0700 (PDT) Message-ID: <37CF9512.13A65127@lyra.org> Date: Fri, 03 Sep 1999 02:29:54 -0700 From: Greg Stein X-Mailer: Mozilla 3.01 (X11; I; Linux 2.0.28 i586) MIME-Version: 1.0 To: new-httpd@apache.org Subject: Re: cvs commit: apache-2.0/src/lib/apr/network_io/unix sendrecv.c sockets.c References: <19990902203346.21423.qmail@hyperreal.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org rbb@hyperreal.org wrote: >... > ap_status_t ap_recv(struct socket_t *sock, char *buf, ap_ssize_t *len, time_t sec) > { >... > + if (sec == -1) { Can you truly rely on time_t being a signed type? I don't think that you can. >... > +/* ***APRDOC******************************************************** > + * ap_status_t ap_setipaddr(ap_socket_t *, apr_uint32_t addr) > + * Assocaite a socket addr with an apr socket. > + * arg 1) The socket to use > + * arg 2) The IP address to attach to the socket. > + * NOTE: This does not bind the two together, it is just telling apr > + * that this socket is going to use this address if possible. > + */ > +ap_status_t ap_setipaddr(struct socket_t *sock, const char *addr) > +{ Nit: the comments don't match the function. Cheers, -g -- Greg Stein, http://www.lyra.org/