httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/network_io/unix sockets.c
Date Tue, 14 Sep 1999 16:56:23 GMT


On Tue, 14 Sep 1999, Ben Laurie wrote:

> Dean Gaudet wrote:
> > 
> > On Sun, 12 Sep 1999, Manoj Kasichainula wrote:
> > 
> > > On Sun, Sep 12, 1999 at 10:30:46AM -0700, Greg Stein wrote:
> > > > inet_ntoa() returns a pointer to a statically allocated buffer.
> > > > Shouldn't we make a copy of it?
> > >
> > > And if this is the case, should we also mutex it?
> > 
> > please no.  pass in a char * to be filled in with the answer, and
> > sprintf("%u.%u.%u.%u") to it or something intelligent like that.  adding a
> > mutex here is a waste of performance.  and there's about a zillion
> > different platform differences, some of them providing thread-safe
> > versions, some not... why make life hard trying to use the platform
> > version?
> 
> You meant pass a char * and an int and use ap_snprintf, of course :-)

of course :)

Dean


Mime
View raw message