httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-1.3/src/os/win32 mod_isapi.c
Date Tue, 07 Sep 1999 15:08:49 GMT
stoddard@hyperreal.org wrote:
> 
> stoddard    99/08/31 08:22:41
> 
>   Modified:    src/os/win32 mod_isapi.c
>   Log:
>   Fix faulty comparison. MSVC TRUE == 1 while Borland TRUE == -1.
>   PR: 4333, 4887
>   Submitted by: Sergey Verlan

What? This is nonsense. That means Borland have !FALSE != TRUE. Duh.

OTOH, comparing to TRUE is stupid, so I accept the patch.

Cheers,

Ben.

> 
>   Revision  Changes    Path
>   1.18      +1 -1      apache-1.3/src/os/win32/mod_isapi.c
> 
>   Index: mod_isapi.c
>   ===================================================================
>   RCS file: /home/cvs/apache-1.3/src/os/win32/mod_isapi.c,v
>   retrieving revision 1.17
>   retrieving revision 1.18
>   diff -u -r1.17 -r1.18
>   --- mod_isapi.c       1999/01/08 17:54:43     1.17
>   +++ mod_isapi.c       1999/08/31 15:22:40     1.18
>   @@ -172,7 +172,7 @@
> 
>        /* Run GetExtensionVersion() */
> 
>   -    if ((*isapi_version)(pVer) != TRUE) {
>   +    if (!(*isapi_version)(pVer)) {
>         ap_log_rerror(APLOG_MARK, APLOG_ALERT, r,
>                     "ISAPI GetExtensionVersion() failed: %s", r->filename);
>         FreeLibrary(isapi_handle);
> 
> 
> 

--
http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi

Mime
View raw message