httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/network_io/unix sendrecv.c sockets.c
Date Fri, 03 Sep 1999 09:29:54 GMT
rbb@hyperreal.org wrote:
>...
>    ap_status_t ap_recv(struct socket_t *sock, char *buf, ap_ssize_t *len, time_t sec)
>    {
>...
>   +            if (sec == -1) {

Can you truly rely on time_t being a signed type? I don't think that you
can.

>...
>   +/* ***APRDOC********************************************************
>   + * ap_status_t ap_setipaddr(ap_socket_t *, apr_uint32_t addr)
>   + *    Assocaite a socket addr with an apr socket.
>   + * arg 1) The socket to use
>   + * arg 2) The IP address to attach to the socket.
>   + * NOTE:  This does not bind the two together, it is just telling apr
>   + *        that this socket is going to use this address if possible.
>   + */
>   +ap_status_t ap_setipaddr(struct socket_t *sock, const char *addr)
>   +{

Nit: the comments don't match the function.

Cheers,
-g

--
Greg Stein, http://www.lyra.org/

Mime
View raw message