Return-Path: <new-httpd-owner-new-httpd-archive=hyperreal.org@apache.org>
Delivered-To: new-httpd-archive@hyperreal.org
Received: (qmail 13775 invoked by uid 6000); 12 Aug 1999 15:59:44 -0000
Received: (qmail 13764 invoked from network); 12 Aug 1999 15:59:42 -0000
Received: from fanf.noc.demon.net (195.11.55.83)
  by taz.hyperreal.org with SMTP; 12 Aug 1999 15:59:42 -0000
Received: from fanf by fanf.noc.demon.net with local (Exim 3.02 #13)
	id 11ExGW-000OBX-00
	for new-httpd@apache.org; Thu, 12 Aug 1999 16:59:40 +0100
To: new-httpd@apache.org
From: Tony Finch <dot@dotat.at>
Subject: Re: [BUG] 1.3.8 broke mod_speling
In-Reply-To: <19990812160430.H5486@deejai.mch.sni.de>
References: <19990812144552.B5486@deejai.mch.sni.de>
 <19990812144552.B5486@deejai.mch.sni.de>
Message-Id: <E11ExGW-000OBX-00@fanf.noc.demon.net>
Date: Thu, 12 Aug 1999 16:59:41 +0100
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

Martin Kraemer <Martin.Kraemer@mch.sni.de> wrote:
>
>Actually, when looking at the various (current) 3xx error codes,
>I think it is best to replace the
>>         if (ap_is_HTTP_REDIRECT(status) || (status == HTTP_CREATED)) {
>
>test by either
>
>	  if ((status == HTTP_CREATED) ||
>	      (ap_is_HTTP_REDIRECT(status) &&
>	       (status != HTTP_MULTIPLE_CHOICES &&
>		status != HTTP_NOT_MODIFIED))) {
>
>or (more precise check, avoids error for obsolete 306 code):
>
>	  if (status == HTTP_MOVED_PERMANENTLY  ||
>	      status == HTTP_MOVED_TEMPORARILY  ||
>	      status == HTTP_TEMPORARY_REDIRECT ||
>	      status == HTTP_SEE_OTHER          ||
>	      status == HTTP_USE_PROXY          ||
>	      status == HTTP_CREATED) {
>
>because neither HTTP_NOT_MODIFIED nor HTTP_MULTIPLE_CHOICES
>(or the obsolete 306 response) _require_ a Location: header.

Why not just make the ap_is_HTTP_REDIRECT more specific and have a
broader macro that checks for 3XX codes?

Tony.
-- 
f.a.n.finch    dot@dotat.at    fanf@demon.net    e pluribus unix