From: "Life is hard, and then you die." <ronald@innovation.ch>
Message-Id: <199908120011.CAA00471@chill.innovation.ch>
Subject: Re: [PHP-DEV] More on the error under FreeBSD 2.2.8/A-1.3.8/PHP3.0.12
To: new-httpd@apache.org
Date: Thu, 12 Aug 1999 02:11:12 +0200 (MET DST)
In-Reply-To: <199908120003.UAA00644@devsys.jaguNET.com> from "Jim Jagielski"
 at Aug 11, 99 08:03:39 pm
Content-Type: text
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

One day, Jim Jagielski wrote:
> 
> > > Just noticed this when compiling PHP:
> > > 
> > > gcc -O2    -I. -I.   -I/staff/jim/src/CVS/apache-1.3//src/include -I/staff/jim/src/CVS/apache-1.3//src/os/unix                  -I/usr/local/include/gd -I/usr/local/include/mysql    -c functions/post.c -o functions/post.o
> > > functions/post.c: In function `php3_TreatHeaders':
> > > functions/post.c:511: warning: passing arg 1 of `ap_uudecode' from incompatible pointer type
> > > functions/post.c:511: warning: assignment makes pointer from integer without a cast
> > > 
> > > Hrmmm... This shows up in the dump stack
> > > 
> > 
> > The first argument to ap_uudecode is char * plain_dst, whereas the
> > above assumes a pool *
> > 
> > Methinks functions/post.c should be using ap_puudecode() ??
> 
> Confirmed. The arguments to ap_uudecode() changed. In fact, that
> whole section went through a big change... I'm sure this may effect
> other modules as well.

Yup, I guess this was the wrong thing to do (for 1.3). One possibility
is to rename the new ap_uuencode() to ap_base64encode() and rename the
ap_puuencode() back to ap_uuencode() (and the same for decode).


  Cheers,

  Ronald