From: "David Harris" <dharris@drh.net>
To: <new-httpd@apache.org>
Subject: RE: [patch] ./configure --activate-module bugfix
Date: Sat, 28 Aug 1999 14:30:23 -0400
Message-ID: <000801bef183$63deace0$0500a8c0@delf>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
In-Reply-To: <19990828164954.A62117@engelschall.com>
Importance: Normal
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org


> Errr... actually it was never intended that you specify the _source_, David.
> It was intended that you specify the path as it would be on the AddModule
> line, i.e. with mod_foo.o or libfoo.o. We can accept .c, of course.  But
> whether it makes the situation better, I don't know. Perhaps it would be
> better to document it more carefully in INSTALL?

Okay, I see. Anyway, I just noticed that the --add-module directive can replace
the --activate-module directive in my usage, because if --activate-module is
given a .c file already in src/modules/extra, it will not copy the source file
but use it directly.

Perhaps just patch the documentation to say that --activate-module is for
object files only (as Ralf suggested) and --add-module is for .c files, and it
does not copy them into place if they are already in src/modules/extra. This
avoids the ./configure patch. I've written this up in the below patch, which
includes Ralf's patch.

--- INSTALL.orig        Wed Mar 10 06:52:59 1999
+++ INSTALL     Sat Aug 28 14:45:17 1999
@@ -233,20 +233,22 @@
      Use the --add-module=FILE option to copy a module source file to the
      Apache src/modules/extra/ directory and on-the-fly add an entry for it in
      the configuration file. FILE has to be a valid path to a C source file
-     outside the Apache source tree, for instance /path/to/mod_foo.c. The
added
-     module this is way is automatically activated and enabled. Use this
option
-     to automatically include a simple third-party module to the Apache build
-     process.
+     outside the Apache source tree, for instance /path/to/mod_foo.c, or a
+     path to an already existing C source code file in src/modules/extra/,
such
+     as src/modules/extra/mod_foo.c, in which case no copying will be done.
+     The added module this is way is automatically activated and enabled. Use
+     this option to automatically include a simple third-party module to the
+     Apache build process.

      Use the --activate-module=FILE option to add an entry for an existing
-     module source file into the configuration file on-the-fly. FILE has to be
-     a valid path beginning with "src/modules/", and the file has to have been
-     copied to this location in the Apache source tree before running
-     configure.  The module is automatically enabled. Use this option to
-     automatically include a complex third-party module to the Apache build
-     process where, for instance a module like mod_perl or mod_php3 consisting
-     of more than one file which are created by a third-party configuration
-     scheme.
+     module object or library file into the configuration file on-the-fly.
+     FILE has to be a valid path beginning with "src/modules/", and the
+     corresponding file has to have been copied to this location in the Apache
+     source tree before running configure.  The module is automatically
+     enabled. Use this option to automatically include a complex third-party
+     module to the Apache build process where, for instance a module like
+     mod_perl or mod_php3 consisting of more than one file which are created
+     by a third-party configuration scheme.

      Use the --enable-module=NAME and --disable-module=NAME options to enable
      or disable a particular already distributed module from the Apache

 - David Harris
   Principal Engineer, DRH Internet Services