From new-httpd-owner-new-httpd-archive=hyperreal.org@apache.org Mon Aug 02 22:12:41 1999 Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 22238 invoked by uid 6000); 2 Aug 1999 22:12:22 -0000 Received: (qmail 22197 invoked from network); 2 Aug 1999 22:12:14 -0000 Received: from ns.skylink.it (root@194.177.113.1) by taz.hyperreal.org with SMTP; 2 Aug 1999 22:12:14 -0000 Received: from kim.ispra.webweaving.org (va-187.skylink.it [194.185.55.187]) by ns.skylink.it (8.9.1/8.8.8) with ESMTP id AAA03400; Tue, 3 Aug 1999 00:11:23 +0200 Received: from kim.ispra.webweaving.org (kim.ispra.webweaving.org [10.0.0.2]) by kim.ispra.webweaving.org (8.8.8/8.8.5) with ESMTP id WAA02144; Mon, 2 Aug 1999 22:10:00 GMT X-Passed: MX on Ispra.WebWeaving.org Mon, 2 Aug 1999 22:10:00 GMT and masked X-No-Spam: Neither the receipients nor the senders email address(s) are to be used for Unsolicited (Commercial) Email without the explicit written consent of either party; as a per-message fee is incurred for inbound and outbound traffic to the originator. Posted-Date: Mon, 2 Aug 1999 22:10:00 GMT Date: Tue, 3 Aug 1999 00:10:00 +0200 (CEST) From: Dirk-Willem van Gulik X-Sender: dirkx@kim.ispra.webweaving.org To: new-httpd@apache.org cc: apache-1.3-cvs@hyperreal.org Subject: Re: cvs commit: apache-1.3/src/modules/standard mod_auth.c mod_auth_db.c mod_auth_dbm.c In-Reply-To: <19990802205023.22039.qmail@hyperreal.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org Status: O On 2 Aug 1999 coar@hyperreal.org wrote: > src/include ap.h ap_md5.h ap_sha1.h > src/main http_main.c > src/modules/standard mod_auth.c mod_auth_db.c mod_auth_dbm.c > Removed: src/include ap_checkpass.h I am struggling with the same now; moving a few base64 encoders into one ap_base64.c file. What is the cut-off point for moving all declarations into ap.h as opposed to adding a few individual ap_*.h file ? Or was the current ap_md5.h simply wrong to begin with ? And caused by its legacy start; as an import from elsewhere ? Seeing your change I kind of prefer the ap.h collation; but I wonder a bit, as the base64 and validate_passwd functions are only used in just one or two files. ap.h is not getting any smaller. Or is that a needless worry ? Dw. > RCS file: /home/cvs/apache-1.3/src/include/ap.h,v > retrieving revision 1.21 > retrieving revision 1.22 > diff -u -r1.21 -r1.22 > --- ap.h 1999/05/31 17:09:31 1.21 > +++ ap.h 1999/08/02 20:50:14 1.22 > @@ -159,6 +159,7 @@ > __attribute__((format(printf,3,4))); > API_EXPORT(int) ap_vsnprintf(char *buf, size_t len, const char *format, > va_list ap); > +API_EXPORT(char *) ap_validate_password(const char *passwd, const char *hash); > > #ifdef __cplusplus > } >