httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dirk-Willem van Gulik <di...@webweaving.org>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_auth.c mod_auth_db.c mod_auth_dbm.c
Date Mon, 02 Aug 1999 22:10:00 GMT


On 2 Aug 1999 coar@hyperreal.org wrote:

>                src/include ap.h ap_md5.h ap_sha1.h
>                src/main http_main.c
>                src/modules/standard mod_auth.c mod_auth_db.c mod_auth_dbm.c
>   Removed:     src/include ap_checkpass.h

I am struggling with the same now; moving a few base64 encoders into one
ap_base64.c file.

What is the cut-off point for moving all declarations into ap.h as
opposed to adding a few individual ap_*.h file ?

Or was the current ap_md5.h simply wrong to begin with ? And caused
by its legacy start; as an import from elsewhere ? 

Seeing your change I kind of prefer the ap.h collation; but I wonder a
bit, as the base64 and validate_passwd functions are only used in just
one or two files. ap.h is not getting any smaller. Or is that a 
needless worry ?

Dw.

>   RCS file: /home/cvs/apache-1.3/src/include/ap.h,v
>   retrieving revision 1.21
>   retrieving revision 1.22
>   diff -u -r1.21 -r1.22
>   --- ap.h	1999/05/31 17:09:31	1.21
>   +++ ap.h	1999/08/02 20:50:14	1.22
>   @@ -159,6 +159,7 @@
>    			    __attribute__((format(printf,3,4)));
>    API_EXPORT(int) ap_vsnprintf(char *buf, size_t len, const char *format,
>    			     va_list ap);
>   +API_EXPORT(char *) ap_validate_password(const char *passwd, const char *hash);
>    
>    #ifdef __cplusplus
>    }
>   


Mime
View raw message