httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tony Finch <...@dotat.at>
Subject Re: [BUG] 1.3.8 broke mod_speling
Date Thu, 12 Aug 1999 15:59:41 GMT
Martin Kraemer <Martin.Kraemer@mch.sni.de> wrote:
>
>Actually, when looking at the various (current) 3xx error codes,
>I think it is best to replace the
>>         if (ap_is_HTTP_REDIRECT(status) || (status == HTTP_CREATED)) {
>
>test by either
>
>	  if ((status == HTTP_CREATED) ||
>	      (ap_is_HTTP_REDIRECT(status) &&
>	       (status != HTTP_MULTIPLE_CHOICES &&
>		status != HTTP_NOT_MODIFIED))) {
>
>or (more precise check, avoids error for obsolete 306 code):
>
>	  if (status == HTTP_MOVED_PERMANENTLY  ||
>	      status == HTTP_MOVED_TEMPORARILY  ||
>	      status == HTTP_TEMPORARY_REDIRECT ||
>	      status == HTTP_SEE_OTHER          ||
>	      status == HTTP_USE_PROXY          ||
>	      status == HTTP_CREATED) {
>
>because neither HTTP_NOT_MODIFIED nor HTTP_MULTIPLE_CHOICES
>(or the obsolete 306 response) _require_ a Location: header.

Why not just make the ap_is_HTTP_REDIRECT more specific and have a
broader macro that checks for 3XX codes?

Tony.
-- 
f.a.n.finch    dot@dotat.at    fanf@demon.net    e pluribus unix

Mime
View raw message