httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: 1.3.8: One more bug...
Date Tue, 10 Aug 1999 18:09:31 GMT

In article <19990810181708.A68950@engelschall.com> you wrote:
> 
> Hell, one more bug: mod_vhost_alias cannot be disabled by APACI.
> 
> For instance:
> 
> $ ./configure --enable-module=most --disable-module=vhost_alias
> 
> This still enables mod_vhost_alias. Why? because the sed-command in
> `configure' for mod_alias is applied after the one for mod_vhost_alias and
> this way overrides also the mod_vhost_alias entry. We can only fix this by
> using multiple patterns in `configure' to make the substsitution unique.

I propose the following patch:

Index: configure
===================================================================
RCS file: /e/apache/REPOS/apache-1.3/configure,v
retrieving revision 1.97
diff -u -r1.97 configure
--- configure   1999/08/09 17:05:01 1.97
+++ configure   1999/08/10 16:26:25
@@ -1393,22 +1405,28 @@
 fi
 
 #   generate module directives
+#   (paths are modules/foo/mod_bar.ext and modules/foo/libbar.ext)
 OIFS="$IFS"
 IFS=':'
 for module in $modules; do
     eval "add=\$module_$module"
     if [ "x$add" = "xyes" ]; then
-        echo $SEO "s%^.*\\(AddModule.*[_b/]$module\\..*\\)%\\1%g" >>$sedsubst
-        echo $SEO "s%^.*\\(SharedModule.*[_b/]$module\\..*\\)%\\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(AddModule.*mod_$module\\..*\\)%\\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(AddModule.*lib$module\\..*\\)%\\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(SharedModule.*mod_$module\\..*\\)%\\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(SharedModule.*lib$module\\..*\\)%\\1%g" >>$sedsubst
         m="yes"
     else
-        echo $SEO "s%^.*\\(AddModule.*[_b/]$module\\..*\\)%# \\1%g" >>$sedsubst
-        echo $SEO "s%^.*\\(SharedModule.*[_b/]$module\\..*\\)%# \\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(AddModule.*mod_$module\\..*\\)%# \\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(AddModule.*lib$module\\..*\\)%# \\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(SharedModule.*mod_$module\\..*\\)%# \\1%g" >>$sedsubst
+        echo $SEO "s%^.*\\(SharedModule.*lib$module\\..*\\)%# \\1%g" >>$sedsubst
         m=no
     fi
     eval "share=\$shared_$module"
     if [ "x$share" = "xyes" ]; then
-        echo $SEO "s%^\\(.*\\)AddModule\\(.*[_b/]$module\\.\\)[oam].*\\(.*\\)%\\1SharedModule\\2so\\3%g"
>>$sedsubst
+        echo $SEO "s%^\\(.*\\)AddModule\\(.*mod_$module\\.\\)[oam].*\\(.*\\)%\\1SharedModule\\2so\\3%g"
>>$sedsubst
+        echo $SEO "s%^\\(.*\\)AddModule\\(.*lib$module\\.\\)[oam].*\\(.*\\)%\\1SharedModule\\2so\\3%g"
>>$sedsubst
         m="$m [shared]"
     fi
     if [ "x$verbose" = "xyes" ]; then

Yeah, I know that the modules/foo/bar.quux variant is now no longer supported,
but this variant was bogus. 
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message