httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: [STATUS] (apache-1.3) Sun Jul 25 23:45:06 EDT 1999
Date Tue, 03 Aug 1999 10:26:09 GMT

In article <Pine.BSF.4.10.9908021851380.50439-100000@zippy.machaon.ru> you wrote:
> 
> On Thu, 29 Jul 1999, Rodent of Unusual Size wrote:
> 
>> Dmitry Khrustalev wrote:
>> > 
>> >     What's the point of change in rev 1.137 of mod_rewrite.c?
>> 
>> Changing a strcmp() test from "-s " to "-s"?  Seems straightforward
>> to me..
> 
> That's 1.138. 1.137 is:
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_rewrite.c,v
> retrieving revision 1.136
> retrieving revision 1.137
> diff -p -u -r1.136 -r1.137
> --- apache-1.3/src/modules/standard/mod_rewrite.c	1999/03/07 18:03:34	1.136
> +++ /home/cvs/apache-1.3/src/modules/standard/mod_rewrite.c	1999/04/22 09:54:37	1.137
> @@ -529,7 +529,10 @@ static const char *cmd_rewritemap(cmd_pa
>  static const char *cmd_rewritelock(cmd_parms *cmd, void *dconf, char *a1)
>  {
>      rewrite_server_conf *sconf;
> +    const char *error;
>  
> +    if ((error = ap_check_cmd_context(cmd, GLOBAL_ONLY)) != NULL)
> +        return error;
>      sconf = (rewrite_server_conf *)
>              ap_get_module_config(cmd->server->module_config, &rewrite_module);

It was just to make sure that RewriteLock can be used only in the global
context. Apache has not value for this in the command table, so one has to
deny later in the directive handling function. I've seen from your rewritelock
fix Dean comitted today, that you've already found this out yourself ;)

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message