httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_autoindex.c mod_include.c
Date Thu, 13 May 1999 18:38:57 GMT


On 13 May 1999 coar@hyperreal.org wrote:

>   Index: mod_include.c

I never had a chance to look at Raymond's hacks to mod_include.

>   +#define SUB_REQ_STRING	"Sub request to mod_include"
>   +#define PARENT_STRING	"Parent request to mod_include"

I don't like these #defines spread over two modules.  I don't like modules
which rely on each other. 

>   @@ -2411,9 +2441,10 @@
>        send_parsed_content(f, r);
>    
>        if (parent) {
>   -	/* signify that the sub request should not be killed */
>   -	ap_set_module_config(r->request_config, &includes_module,
>   -	    NESTED_INCLUDE_MAGIC);
>   +	/* Kludge --- Doing this allows the caller to safely destroy the
>   +	 * sub_req
>   +	 */
>   +	r->pool = ap_make_sub_pool(r->pool);

I haven't looked at this for long, but I believe this is totally wrong.

Try building with -DPOOL_DEBUG -DALLOC_DEBUG and see what happens.

I would much rather have Raymod's updates to mod_autoindex separate from
the hacks to mod_include... when I asked for him to post his patches again
"combined" I meant:  post the patches with the style changes... I didn't
mean combine the "evil hack" and the acceptable patch.  I just didn't
want to review a patch on top of a patch.

Dean


Mime
View raw message