httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] Expat patch #3
Date Fri, 21 May 1999 20:57:15 GMT
Ralf S. Engelschall wrote:
> 
> In article <3745C109.78FF503@lyra.org> you wrote:
> >...
> > Ralf: could you remove your veto, or at least alter it to just the
> > http_main.c portion of the patch? (so the src/lib/ stuff can go in)

Would you consider amending your veto until this exporting is resolved?
I'd prefer to not have the entire patch held up, since it also deals
with the src/lib/ move (not just Expat).

> Wait, let me understand it again. What you propose is to just export the
> symbols. Ok, but then doesn't mean that the Expat stuff is really all linked
> into the httpd, isn't it? When all(!) code is linked in, this exporting will
> work, of course. But when not all code gets linked in the exporting is useless
> AFAIK. We do the ap_xx() wrapper stuff not just because of exporting.  We've
> to still export the ap_xx(), of course. We do it to force the linker to
> include the whole(!) Expat into httpd so the whole Expat library is available
> to DSOs when we try to export the stuff.
> 
> When we just try to export the symbols and hope that this way on most
> platforms Expat is forced to be linked into httpd, this is just a guess about
> linker behaviour and not really portable and clean IMHO. That's why I'm still
> not convinced that this "just try to export the symbols" is reasonable.

Name a platform that does this.

Besides, by your argument, ap_xml_xxx() might not be in the link unit.
Nothing calls it, so this smart, hypothetical linker will drop it.

Jens-Uwe Mager said this would work, and it seems that he has been
working a lot with symbol exporting on a bunch of different platforms.
I'm no expert by any means, but it sounds like he knows his stuff. I'm
inclined to go with his suggestion.

In other words, I don't think it is a "try to export the symbols" but it
really is the behavior we want: "export the symbols."

Cheers,
-g

--
Greg Stein, http://www.lyra.org/

Mime
View raw message