Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 19632 invoked by uid 6000); 9 Apr 1999 21:45:17 -0000 Received: (qmail 19613 invoked from network); 9 Apr 1999 21:45:15 -0000 Received: from kurgan.lyra.org (root@208.192.43.9) by taz.hyperreal.org with SMTP; 9 Apr 1999 21:45:15 -0000 Received: from kurgan.lyra.org (IDENT:gstein@localhost [127.0.0.1]) by kurgan.lyra.org (8.9.2/8.9.2) with SMTP id OAA24075 for ; Fri, 9 Apr 1999 14:46:19 -0700 (PDT) Message-ID: <370E7528.42F72EE@lyra.org> Date: Fri, 09 Apr 1999 14:46:16 -0700 From: Greg Stein X-Mailer: Mozilla 3.01 (X11; I; Linux 2.0.28 i586) MIME-Version: 1.0 To: new-httpd@apache.org Subject: Re: cvs commit: apache-apr/include apr_file_io.h References: <19990409180300.14125.qmail@hyperreal.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org rbb@hyperreal.org wrote: > > rbb 99/04/09 11:02:59 > > Modified: apr/file_io/unix readwrite.c > apr/test testfile.c > docs fileio.txt > include apr_file_io.h > Log: > Added apr_writev call, and requisite defines. I also added the permissions > abstraction #defines. >... > - > -apr_ssize_t apr_read(apr_file_t *thefile, void *buf, apr_size_t nbytes) > +#include > +apr_ssize_t apr_read(apr_file_t *thefile, void *buf, apr_ssize_t nbytes) I think this is wrong. On my Linux box here, I see that "nbytes" is listed as a size_t, NOT an ssize_t. It does *return* and ssize_t, though. >... > +apr_ssize_t apr_writev(apr_file_t *thefile, const apr_iovec_t * vec, apr_ssize_t iocnt) On my system, that last parameter is an integer count (of iovec structs), not an ssize_t. IMO, these parameters should be changed to an ssize_t and an int until another platform is found which defines them differently. At that point, a choice will need to be made. Cheers, -g -- Greg Stein, http://www.lyra.org/