httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] TPF port
Date Mon, 19 Apr 1999 17:14:53 GMT


On Mon, 19 Apr 1999 moenich@us.ibm.com wrote:

> >> +#if !defined(WIN32) & !defined(TPF)
> >>      /* protect various fd_sets */
> >>      if (s >= FD_SETSIZE) {
> >>   ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_WARNING, NULL,
> 
> > smells like something we may want to have a common define for:
> 
> >     CHECK_FD_SETSIZE
> 
> > or something like that.
> 
> If there's a concensus I'd be happy to start working on it.  Perhaps
> globally define it for everyone and undef it for WIN32 and TPF?

Sounds cool to me.

> > ... http_main.c is such a mess of #ifdefs, eh?
> 
> I remember attempting to remove all the #ifdefs over a year ago, trying to
> see what code I was actually running through.  Yikes!

Yeah I made an attempt in apache-nspr as well.  My plan there was to
delete everything and start from scratch... hoping to split things up by
platforms more in to the platform specific code.  I don't think I
succeeded very well.

Abstracting out the scoreboard and mutexes (ralf did this in EAPI) is a
nice start.  That removes a lot of the conditionals. 

Dean


Mime
View raw message