httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] TPF port
Date Sat, 17 Apr 1999 00:32:59 GMT
> @@ -3060,8 +3138,8 @@
>      }
>  #endif /*_OSD_POSIX*/
>      one = 1;
> -#ifndef BEOS
> -/* BeOS does not support SO_KEEPALIVE */
> +#if !defined(BEOS) && !defined(TPF)
> +/* BeOS and TPF do not support SO_KEEPALIVE */
>      if (setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, (char *) &one, sizeof(int)) <
0) {
>  	ap_log_error(APLOG_MARK, APLOG_CRIT, server_conf,
>  		    "make_sock: for %s, setsockopt: (SO_KEEPALIVE)", addr);

Why don't we just change that to:

#ifdef SO_KEEPALIVE
    if (setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, ...
    ...
#endif

> +#if !defined(WIN32) & !defined(TPF)
>      /* protect various fd_sets */
>      if (s >= FD_SETSIZE) {
>  	ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_WARNING, NULL,

smells like something we may want to have a common define for:

    CHECK_FD_SETSIZE

or something like that.



... http_main.c is such a mess of #ifdefs, eh?


Dean

Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message