httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raymond S Brand <>
Subject Re: [PATCH] EVIL hack
Date Wed, 28 Apr 1999 14:36:15 GMT
"Ralf S. Engelschall" wrote:
> It's really an EVIL hack, and this way not acceptable. Because it at least
> totally breaks the DSO facility for both modules. The only way you can do such

Agreed! That's why I broke it out separately and gave it the eye catching name.
Also, I was hoping for some discussion of or pointers to a good way of solving
the problem.

> inter-module communication/calls is via EAPI hooks in the future.  With EAPI
> you just register a hook inside mod_include and call this hook from within
> mod_autoindex. That's safe and clean. Actually such a loosly coupled calling
> mechanism is the only chance to overcome the inherent restrictions of the DSO
> facility.

I haven't paid much attention to the EAPI discussion so far. Does the EAPI
proposal exist as a document/code somewhere or do I need to go back through the
list archives?

> I've not thought about your particular environment variable problem itself
> now. Perhaps there is an alternative solution, of course. At least the
> suggested way it breaks too much.

The short term solution I'm using is to do a "RewiteEngine On" in the conf file
and use ${SCRIPT_URL} in the included documents instead of ${SCRIPT_NAME} for
path related messages (I don't use the EVIL hack). The long term solution is
to somehow flag a sub_req request_req so that mod_include knows to use the
parent request_req env vars.

The patch to mod_autoindex is very usable without the EVIL hack. The env vars
that are not set correctly in the included header and readme are:

	QUERY_STRING		could possibly be fixed up in mod_autoindex
	LAST_MODIFIED		this hurts

Raymond S Brand

View raw message